netdev - Re: [PATCH] sky2: don't do GRO on second port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1283491432.3699.1371.camel@edumazet-laptop>
Date:	Fri, 03 Sep 2010 07:23:52 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Jarek Poplawski <jarkao2@...il.com>,
	David Miller <davem@...emloft.net>, shemminger@...tta.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: don't do GRO on second port

Le vendredi 03 septembre 2010 à 05:26 +0800, Herbert Xu a écrit :
> On Thu, Sep 02, 2010 at 12:41:45PM +0200, Eric Dumazet wrote:
> > 
> > [PATCH net-next-2.6] gro: remove use of napi->dev
> > 
> > Only use of napi->dev in GRO stack is the one found in napi_get_frags()
> > 
> > We can remove it and use a plain dev_alloc_skb() call.
> > 
> > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Why do you think napi->dev is not needed?

Origin was that sky2 could use one napi and two devices on it.
No bug, only a conceptual problem using a napi->dev.

Then, there is a small second point :

netdev_alloc_skb_ip_align() is using 'device' NUMA node to allocate
memory.

In this context, this makes litle sense because this skb is not going to
be used by the device. Its a pure software one, for the sake of GRO
handling.

It would be more efficient to allocate an skb on NUMA node of the CPU
handling the softirq.

Thanks

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html