[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100903.083409.52185570.davem@davemloft.net>
Date: Fri, 03 Sep 2010 08:34:09 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: paulmck@...ux.vnet.ibm.com
Cc: herbert@...dor.apana.org.au, linville@...driver.com,
netdev@...r.kernel.org, mingo@...e.hu,
linux-kernel@...r.kernel.org, peterz@...radead.org
Subject: Re: [PATCH] netpoll: use non-BH variant of RCU
From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Date: Thu, 2 Sep 2010 10:26:25 -0700
> softirq: adjust error check
>
> The error check for _local_bh_enable_ip() warns on both in_irq() and
> irqs_disabled(). The check for in_irq() is necessary, because a hardirq
> might well have interrupted bh execution, in which case it is simply
> not possible for the hardirq to exclude the bh that got interrupted.
>
> However, it is perfectly reasonable to disable bh while hardirqs are
> disabled, and this in fact promotes common code. This commit therefore
> removes the irqs_disabled() check.
>
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists