netdev - PATCH: b44 Handle RX FIFO overflow better (simplified)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1283645879.1672.2.camel@corey>
Date:	Sat, 04 Sep 2010 20:17:59 -0400
From:	Mark Lord <kernel@...savvy.com>
To:	"linux-kernel-owner@...r.kernel.org" 
	<linux-kernel-owner@...r.kernel.org>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	James@...erbug.co.uk
Subject: PATCH: b44 Handle RX FIFO overflow better (simplified)

This patch is a simplified version of the original patch from James Courtier-Dutton.

>From: James Courtier-Dutton
>Subject: [PATCH] Fix b44 RX FIFO overflow recovery.
>Date: Wednesday, June 30, 2010 - 1:11 pm
>
>This patch improves the recovery after a RX FIFO overflow on the b44
>Ethernet NIC.
>Before it would do a complete chip reset, resulting is loss of link
>for a few seconds.
>This patch improves this to do recovery in about 20ms without loss of link.
>
>Signed off by: James@...erbug.co.uk

Signed-off-by: Mark Lord <mlord@...ox.com>

--- a/drivers/net/b44.c	2010-09-04 20:02:27.539248270 -0400
+++ b/drivers/net/b44.c	2010-09-04 20:07:03.749248234 -0400
@@ -851,6 +851,15 @@
 		b44_tx(bp);
 		/* spin_unlock(&bp->tx_lock); */
 	}
+	if (bp->istat & ISTAT_RFO) {	/* fast recovery, in ~20msec */
+		bp->istat &= ~ISTAT_RFO;
+		b44_disable_ints(bp);
+		ssb_device_enable(bp->sdev, 0); /* resets ISTAT_RFO */
+		b44_init_rings(bp);
+		b44_init_hw(bp, B44_FULL_RESET_SKIP_PHY);
+		netif_wake_queue(bp->dev);
+	}
+
 	spin_unlock_irqrestore(&bp->lock, flags);
 
 	work_done = 0;


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html