netdev - net: af_packet: skb_orphan should be avoided in TX path.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=oXDgEhEjt7V+Z4Pk8kv9X4Z8aCg2yAJDzuJ1J@mail.gmail.com>
Date:	Mon, 6 Sep 2010 01:18:06 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Linux Netdev List <netdev@...r.kernel.org>
Subject: net: af_packet: skb_orphan should be avoided in TX path.

af_packet uses tpacket_destruct_skb() to notify its user a frame is
sent out through NIC, and the memory for that frame is available for
the others. If the driver calls skb_orphan() before the frame is sent
out successfully, and the user may fill other data into the space for
this frame, this frame will be corrupted. It became more likely after
skb_try_orphan() was added into dev_hard_start_xmit().

Am I correct?

-- 
Regards,
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html