netdev - Re: STMMAC: sleep inside atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C84B8A8.5080503@st.com>
Date:	Mon, 6 Sep 2010 11:47:20 +0200
From:	Peppe CAVALLARO <peppe.cavallaro@...com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	ML netdev <netdev@...r.kernel.org>
Subject: Re: STMMAC: sleep inside atomic

 Hi Jiri,
On 9/4/2010 1:47 PM, Jiri Slaby wrote:
>
> Hi,
>
> stanse found that the driver may sleep inside atomic:
> stmmac_resume
>   -> spin_lock
>   -> stmmac_open
>     -> request_irq
>     -> kzalloc(..., GFP_KERNEL);
>     -> init_dma_desc_rings
>       -> kmalloc(..., GFP_KERNEL);
>     -> and many others...
>   -> spin_unlock
>
> Could you fix that?
>
Yes I could ...  kmalloc(...,GFP_KERNEL) can sleep!
I will fix the spinlock usage in the driver's resume function and send a
patch to the mailing list asap.

Many thanks to have found it.

Regards,
Peppe
>
>
> regards,
> --
> js
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html