netdev - Re: PATCH: usbnet: doc updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100905.171227.193704987.davem@davemloft.net>
Date:	Sun, 05 Sep 2010 17:12:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	david-b@...bell.net
Cc:	netdev@...r.kernel.org, linux@...nbow-software.org
Subject: Re: PATCH: usbnet: doc updates

From: David Brownell <david-b@...bell.net>
Date: Sun, 5 Sep 2010 17:06:10 -0700 (PDT)

> Apologies in advance for sending this as an
> attachment, but I think it's less likely to get
> angled (except quoted-printable?) this way.

Well, patchwork didn't grok it at all, and this means your patch is a
lot more work for me.

Actually looking at the patch, the comment formatting is not all
that pretty:

+ * Note that the design center for usbnet has one IEEE packet per URB, and
+maps network TX and RX queues directly to the USB hardware TX/RX queues,

Please start every line of the comment with the
proper leading " * " rather than going straight to
the text.

+	/* fixup rx packet ( by stripping framing from URB/SKB.
+	 *
+	 - If SKB batches one or more packets, pass all but one of them
+	   up the stack (clone SKB and fixup each clone before netif_rx)).

Please also do the same here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html