lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100906122344.GA2764@bicker> Date: Mon, 6 Sep 2010 14:26:39 +0200 From: Dan Carpenter <error27@...il.com> To: Vlad Yasevich <vladislav.yasevich@...com> Cc: Sridhar Samudrala <sri@...ibm.com>, "David S. Miller" <davem@...emloft.net>, Wei Yongjun <yjwei@...fujitsu.com>, Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>, linux-sctp@...r.kernel.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: [patch] sctp: fix test for end of loop "new_addr" is the list cursor here and it's always non-NULL. We're trying to test if we exited because the loop ended or we hit the break statement. Really testing !found is enough so long as "new_asoc->peer.transport_addr_list" is not empty and I believe it never is empty at this point. So this is never really a bug with the current code. Signed-off-by: Dan Carpenter <error27@...il.com> --- Compile tested only. diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 24b2cd5..cb76d2e 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -1254,7 +1254,6 @@ static int sctp_sf_check_restart_addrs(const struct sctp_association *new_asoc, /* Search through all current addresses and make sure * we aren't adding any new ones. */ - new_addr = NULL; found = 0; list_for_each_entry(new_addr, &new_asoc->peer.transport_addr_list, @@ -1273,7 +1272,8 @@ static int sctp_sf_check_restart_addrs(const struct sctp_association *new_asoc, } /* If a new address was added, ABORT the sender. */ - if (!found && new_addr) { + if (!found && + &new_addr->transports != &new_asoc->peer.transport_addr_list) { sctp_sf_send_restart_abort(&new_addr->ipaddr, init, commands); } -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists