netdev - Re: [PATCH] net: fix tx queue selection for bridged devices implementing select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100906.174816.102563052.davem@davemloft.net>
Date:	Mon, 06 Sep 2010 17:48:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	helmut.schaa@...glemail.com
Cc:	netdev@...r.kernel.org, johannes@...solutions.net,
	krkumar2@...ibm.com
Subject: Re: [PATCH] net: fix tx queue selection for bridged devices
 implementing select_queue

From: Helmut Schaa <helmut.schaa@...glemail.com>
Date: Fri,  3 Sep 2010 14:39:56 +0200

> When a net device is implementing the select_queue callback and is part of
> a bridge, frames coming from the bridge already have a tx queue associated
> to the socket (introduced in commit a4ee3ce3293dc931fab19beb472a8bde1295aebe,
> "net: Use sk_tx_queue_mapping for connected sockets"). The call to
> sk_tx_queue_get will then return the tx queue used by the bridge instead
> of calling the select_queue callback.
> 
> In case of mac80211 this broke QoS which is implemented by using the
> select_queue callback. Furthermore it introduced problems with rt2x00
> because frames with the same TID and RA sometimes appeared on different
> tx queues which the hw cannot handle correctly.
> 
> Fix this by always calling select_queue first if it is available and only
> afterwards use the socket tx queue mapping.
> 
> Signed-off-by: Helmut Schaa <helmut.schaa@...glemail.com>

Applied to net-2.6, thanks Helmut.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html