netdev - Re: [PATCHv4] net: Add batman-adv meshing protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201009072024.53048.sven.eckelmann@gmx.de>
Date:	Tue, 7 Sep 2010 20:24:51 +0200
From:	Sven Eckelmann <sven.eckelmann@....de>
To:	paulmck@...ux.vnet.ibm.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	b.a.t.m.a.n@...ts.open-mesh.net
Subject: Re: [PATCHv4] net: Add batman-adv meshing protocol

Paul E. McKenney wrote:
[..]
> > > I have similar concerns with your other RCU read-side critical
> > > sections.
> > 
> > Looks to me like a valid point. I have to think a little bit how to solve
> > it correctly. Feel free to add more comments about other rcu cruelties
> > in it.
> 
> One approach would be to extend the RCU read-side critical section to
> cover all uses of the RCU-protected pointer.  Another approach would be
> to take a reference count (or something similar) before the pointer
> leaves the RCU read-side critical section.

I am not the author of the rcu related functionality (it was one of the actual 
maintainers: Simon Wunderlich), but would guess that the rcu protected 
"critical section" will be extended.

> Could you please take a look at Documentation/RCU/checklist.txt?
> 
> Because I am not familiar with the BATMAN device, it is all too easy
> for me to miss subtleties in the code.

Yes, will be done (will probably end in reading all the rcu documentation). 
But it is really nice that you checked the code for your area of interest.

thanks,
	Sven

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)