netdev - Re: [net-next-2.6 PATCH] e1000: fix Tx hangs by disabling 64-bit DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100908.142207.258102173.davem@davemloft.net>
Date:	Wed, 08 Sep 2010 14:22:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com, bphilips@...ell.com,
	jesse.brandeburg@...el.com
Subject: Re: [net-next-2.6 PATCH] e1000: fix Tx hangs by disabling 64-bit
 DMA

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 08 Sep 2010 00:01:12 -0700

> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> Several users report issues with 32-bit adapters when plugged
> into PCI slots in machines with >= 4GB ram.  In particular AMD
> systems with HyperTransport to PCI bridges seem to trigger the
> issue, but it isn't limited to only them.
> 
> This issue is not easily reproducible here, yet still continues
> to occur in the field.  For e1000 on PCI devices, just disable DMA
> addresses over the 4GB boundary when in PCI (not PCI-X) mode, to
> prevent the issue from continuing to pop up.  The performance
> impact for this is negligible.
> 
> The code was refactored to move the init of the hw struct to its
> own function. This allows the init to be called very early in
> probe, which then allows using hw-> members for this fix.
> 
> A slight refactor to the DMA mask code was done for minor
> correctness based on the instructions in DMA-API-HOWTO.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, thanks guys.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html