lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Sep 2010 14:14:42 +0800 From: jovi zhang <bookjovi@...il.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Johannes Berg <johannes.berg@...el.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, Alexey Dobriyan <adobriyan@...nvz.org>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] netlink: Fix kfree NULL pointer On Wed, Sep 8, 2010 at 1:55 PM, Eric Dumazet <eric.dumazet@...il.com> wrote: > Le mercredi 08 septembre 2010 à 13:33 +0800, jovi zhang a écrit : > >> YES, maybe kfree(NULL) is legal, but I cannot see there have any need >> to invoke kfree(NULL) in this function. >> Also I check kfree usage in other code, I havn't find any kfree(NULL) usage. > > We have hundred call sites doing kfree(NULL), if it makes code shorter. > > Its usually code path handling exceptions (errors if you prefer), and we > prefer to use ugly gotos, and even kfree(NULL), to make it as short as > possible. OK, I understand. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists