netdev - Re: Is via-velocity broken in 2.6.34?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=kbonQ11mLpkd4EnSr3ch8yDssnjaUsgw_tVw9@mail.gmail.com>
Date:	Wed, 8 Sep 2010 08:27:19 -0700
From:	Matt Causey <matt.causey@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: Is via-velocity broken in 2.6.34?

On Tue, Sep 7, 2010 at 5:24 PM, David Miller <davem@...emloft.net> wrote:
> From: Matt Causey <matt.causey@...il.com>
> Date: Tue, 7 Sep 2010 17:13:14 -0700
>
>> So before I posted to the list, I actually dug through looking for
>> recent changes which would be trivial for me to back out.  This was
>> the only one I had found, so I tried it.  :-)  No luck though...same
>> result.
>
> Thanks, please continue reading up on how to bisect this down,
> that will help us figure out what the problem is.
>

Apologies, my troubleshooting was faulty.  In my testing when I was
switching between 2.6.29 / 2.6.34 there was a .config change that I
failed to notice.  In my  2.6.29 config I had all the default
config_pm and acpi options enabled, whereas in the later config I had
them all disabled.

So, the minimum acpi stuff needed for the driver to function is
CONFIG_PM and CONFIG_ACPI.  None of the timer stuff or anything else
appears to be necessary.  If that's the case (others can correct me if
not...) could we patch the Kconfig to look like this:

config VIA_VELOCITY
        tristate "VIA Velocity support"
        depends on PCI && PM && ACPI

since today it's only depending on pci.

If this is the right thing to do I can submit a patch .  Apologies
again for the red herring.  :-)

Cheers,

--
Matt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html