| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Sep 2010 09:08:17 +0000 From: Jarek Poplawski <jarkao2@...il.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: David Miller <davem@...emloft.net>, jesse@...ira.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next-2.6] net: inet_add_protocol() can use cmpxchg() On Thu, Sep 09, 2010 at 07:24:53AM +0000, Jarek Poplawski wrote: > On Thu, Sep 09, 2010 at 07:09:26AM +0000, Jarek Poplawski wrote: > > On Thu, Sep 09, 2010 at 08:55:45AM +0200, Eric Dumazet wrote: > > > Le jeudi 09 septembre 2010 ?? 06:42 +0000, Jarek Poplawski a écrit : > > > > Of course, each case is different, but generally I understand Jesse's > > > > concern. Smaller data section argument shouldn't be enough. There is > > > > some reason we do it in C not asm, and there is some cost of > > > > unreadable code too. > > > > > > Sure, but is cmpxchg() really not readable for you ? ;) > > > > Just like for Jesse: "this takes a little more thought". ;-) > > But more exactly, it's not about this one line, but the time you need > when reading this after some time to tell: yes, this place is properly > locked for sure. And most exactly, without "after some time" I couldn't tell this either. Is seems some barriers might have been changed, but I might be wrong. Anyway, it would be nice to have some comment on that in the changelog. Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists