netdev - Re: [PATCH net-next-2.6] ethtool: Complete kernel-doc comments for RX flow filter and hash control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Sep 2010 14:52:33 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
Cc:	santwona.behera@....com, peter.p.waskiewicz.jr@...el.com,
	netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
	dm@...lsio.com
Subject: Re: [PATCH net-next-2.6] ethtool: Complete kernel-doc comments for
 RX flow filter and hash control

On Wed, 2010-09-08 at 14:05 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Tue, 07 Sep 2010 15:46:20 +0100
> 
> > On Tue, 2010-09-07 at 15:41 +0100, Ben Hutchings wrote:
> >> There are now several interfaces within the ethtool API for getting
> >> and setting RX flow filtering and hashing behaviour, most of which are
> >> poorly documented.  This adds kernel-doc comments for all these
> >> interfaces, based on the existing incomplete comments and on the
> >> initial implementations.
> >> 
> >> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> >> ---
> >> Santwona, Peter,
> >> 
> >> Please point out any errors and any information that should be added to
> >> the comments to explain the significant differences between the RXNFC
> >> and RXNTUPLE interfaces.
> > [...]
> >> +/**
> >> + * struct ethtool_rx_ntuple - command to get or set RX flow filter
> >> + * @cmd: Specific command number - %ETHTOOL_GRXNTUPLE or %ETHTOOL_SRXNTUPLE
> > 
> > Of course this is wrong - ETHTOOL_GRXNTUPLE uses struct ethtool_gstrings
> > instead.
> 
> Ben, please submit a fixed up version of the patch.

Will do, but I'm still waiting for feedback from Santwona and Peter.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html