| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <704982.67431.qm@web180312.mail.gq1.yahoo.com> Date: Sat, 11 Sep 2010 12:07:59 -0700 (PDT) From: David Brownell <david-b@...bell.net> To: Ondrej Zary <linux@...nbow-software.org> Cc: netdev@...r.kernel.org, Kernel development list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] usbnet: do not count empty skbs as errors in rx_process() --- On Fri, 9/10/10, Ondrej Zary <linux@...nbow-software.org> wrote: > From: Ondrej Zary <linux@...nbow-software.org> > Subject: [PATCH v2] usbnet: do not count empty skbs as errors in rx_process() NAK to this backwards-incompatible change. At this point there's no way to know how many drivers it breaks ... I do know that counting such SKBs as errors has previously turned up link-level errors, and thus led to bugfixes. > If rx_fixup() returns an empty skb > (because it consumed all data inside), The canonical reason the SKB would be empty is because after rx_fixup() removed all header and trailer data, there was no packet body left. Which is likely a link error, and has been worth accounting as such in the past (turned up bugs on TX or RX sides). > do not count it as error. > > This is needed for cx82310_eth. I'd far rather see that driver fixed, than see the core usbnet framework broken to avoid such fixes to a very new driver ... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists