[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100912.120230.71108625.davem@davemloft.net>
Date: Sun, 12 Sep 2010 12:02:30 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jirislaby@...il.com
Cc: ddutt@...cade.com, rmody@...cade.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: bna: potential null dereference
From: Jiri Slaby <jirislaby@...il.com>
Date: Sat, 04 Sep 2010 14:59:54 +0200
> stanse found a potential null dereference:
> bnad_cb_tx_cleanup
> -> struct bnad_unmap_q *unmap_q = tcb->unmap_q;
> -> -- tcb cannot be null now --
> -> if (!tcb || (!tcb->unmap_q))
>
> The thing is I have no idea whether the second parameter of cleanup may
> be null (move assignment after the check) or not (remove the check)
>
> Could you fix that?
Since the Brocade folks can't be bothered to fix this for more than
a week I'll take care of this, thanks Jiri.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists