lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100912.132445.112598025.davem@davemloft.net> Date: Sun, 12 Sep 2010 13:24:45 -0700 (PDT) From: David Miller <davem@...emloft.net> To: blp@...stanford.edu Cc: jarkao2@...il.com, eric.dumazet@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next-2.6] net: pskb_expand_head() optimization From: Ben Pfaff <blp@...stanford.edu> Date: Sun, 12 Sep 2010 12:55:54 -0700 > David Miller <davem@...emloft.net> writes: > >>> 3) since skb_clone has some cost too, why e.g. saving only the pointer >>> to the tail of the list in skb_shared_info isn't enough? >> >> Then we won't get the rest of the advantages of using list_head such >> as prefetching during traversals, automatic debugging facilities, et al. > > Did you see the recent patch from Andi Kleen where he proposes > removing this prefetching in most situations because the costs > outweigh the benefits on most modern architectures? > http://permalink.gmane.org/gmane.linux.kernel/1033281 > > I'm not saying that list_head doesn't have other advantages > though. Yes I saw it and I somewhat disagree with him, but don't care enough to argue with him about it. There are much more important things to apply my mind and time to at the moment :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists