netdev - Re: [PATCH] enable getsockopt() for IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100912215230.GA2091@jolsa.Belkin>
Date:	Sun, 12 Sep 2010 23:52:30 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Michael Kerrisk <mtk.manpages@...il.com>
Cc:	eric.dumazet@...il.com, jengelh@...ozas.de, kaber@...sh.net,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	linux-man@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH] enable getsockopt() for IP_NODEFRAG

On Sat, Sep 11, 2010 at 08:26:56AM +0200, Michael Kerrisk wrote:
> Hello Jiri
> 
> While integrating your man-pages patch for IP_NODEFRAG, I noticed 
> that this option is settable by setsockopt(), but not gettable by 
> getsockopt(). I suppose this is not intended. The (untested, 
> trivial) patch below adds getsockopt() support.
> 
> The patch is against 2.6.36-rc3.
> 
> Cheers,
> 
> Michael
> 
> PS I've just configured Thunderbird on this machine, hopefully the 
> patch is not mangled. Please let me know if there are problems.
hi,

applied ok, compiled ok ;) thanks

Acked-by: Jiri Olsa <jolsa@...hat.com>

> 
> Signed-off-by: Michael kerrisk <mtk.manpages@...il.com>
> 
> --- net/ipv4/ip_sockglue.c.orig	2010-09-11 07:25:58.000000000 +0200
> +++ net/ipv4/ip_sockglue.c	2010-09-11 07:43:43.000000000 +0200
> @@ -1129,6 +1129,9 @@ static int do_ip_getsockopt(struct sock
>  	case IP_HDRINCL:
>  		val = inet->hdrincl;
>  		break;
> +	case IP_NODEFRAG:
> +		val = inet->nodefrag;
> +		break;
>  	case IP_MTU_DISCOVER:
>  		val = inet->pmtudisc;
>  		break;
> -- 
> Michael Kerrisk
> Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
> Watch my Linux system programming book progress towards publication!
> http://blog.man7.org/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html