netdev - Re: [PATCH net-next-2.6] ipip: get rid of ipip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1284583777.2462.33.camel@edumazet-laptop>
Date:	Wed, 15 Sep 2010 22:49:37 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6] ipip: get rid of ipip_lock

Le mercredi 15 septembre 2010 à 19:28 +0200, Eric Dumazet a écrit :
> As RTNL is held while doing tunnels inserts and deletes, we can remove
> ipip_lock spinlock. My initial RCU conversion was conservative and
> converted the rwlock to spinlock, with no RTNL requirement.
> 
> Use appropriate rcu annotations and modern lockdep checks as well.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

While doing ip_gre conversion, I realize I should define a new helper

/**
 * rtnl_dereference - rcu_dereference with debug checking
 * @p: The pointer to read, prior to dereferencing
 *
 * Do an rcu_dereference(p), but check caller holds RTNL
 */
#define rtnl_dereference(p)					\
	rcu_dereference_check(p, lockdep_rtnl_is_held())



I'll submit a patch serie :

1/3) net: add rtnl_dereference
2/3) ipip: get rid of ipip_lock
3/3) gre: get rid of ipgre_lock

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html