[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.01.1009152309140.6445@obet.zrqbmnf.qr>
Date: Wed, 15 Sep 2010 23:09:31 +0200 (CEST)
From: Jan Engelhardt <jengelh@...ozas.de>
To: Patrick McHardy <kaber@...sh.net>
cc: Luciano Coelho <luciano.coelho@...ia.com>,
netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
sameo@...ux.intel.com, janne.ylalehto@...ia.com
Subject: Re: [PATCH RESEND 1/3] netfilter: xtables: inclusion of
xt_condition
On Wednesday 2010-09-15 22:59, Patrick McHardy wrote:
>On 15.09.2010 22:52, Jan Engelhardt wrote:
>>
>> On Wednesday 2010-09-15 22:39, Patrick McHardy wrote:
>>> Am 17.08.2010 10:36, schrieb Luciano Coelho:
>>>> +/* Defaults, these can be overridden on the module command-line. */
>>>> +static unsigned int condition_list_perms = S_IRUGO | S_IWUSR;
>>>> +static unsigned int condition_uid_perms = 0;
>>>> +static unsigned int condition_gid_perms = 0;
>>>
>>> I'm not sure whether we already discussed this, but this isn't
>>> useful if namespaces are used since the IDs aren't global.
>>
>> Well it's also done for other xt modules that offer a procfs interface.
>> It does not really cost much to have this present I'd say.
>
>They should simply set the permissions for the current namespace.
>
IIRC, the namespace stuff was going to be a later patch to keep
early patches simpler.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists