netdev - Re: [PATCH] r8169: Handle rxfifo errors on 8168 chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100915222719.GA13385@electric-eye.fr.zoreil.com>
Date:	Thu, 16 Sep 2010 00:27:19 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	netdev@...r.kernel.org, jglisse@...hat.com
Subject: Re: [PATCH] r8169: Handle rxfifo errors on 8168 chips

Matthew Garrett <mjg@...hat.com> :
[...]
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 078bbf4..a0da4a1 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
[...]
> @@ -4625,8 +4625,7 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance)
>  		}
>  
>  		/* Work around for rx fifo overflow */
> -		if (unlikely(status & RxFIFOOver) &&
> -		(tp->mac_version == RTL_GIGA_MAC_VER_11)) {
> +		if (unlikely(status & RxFIFOOver)) {
>  			netif_stop_queue(dev);
>  			rtl8169_tx_timeout(dev);
>  			break;


Acked-by: Francois Romieu <romieu@...zoreil.com>

Realtek's driver does something similar with the revision RTL_GIGA_MAC_VER_11
of the 8168.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html