netdev - Re: [RFC PATCH] ipv4: release dev refcnt early when destroying inetdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1284530484.2271.5.camel@edumazet-laptop>
Date:	Wed, 15 Sep 2010 08:01:24 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	nicolas.dichtel@...nd.com, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] ipv4: release dev refcnt early when destroying
 inetdev

Le mardi 14 septembre 2010 à 13:45 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Fri, 10 Sep 2010 17:16:14 +0200
> 
> > Le vendredi 10 septembre 2010 à 16:57 +0200, Nicolas Dichtel a écrit :
> > 
> >> Is this not true in IPv6? What is the difference?
> > 
> > It might be a bug on ipv6, who knows ?
> > 
> > Releasing a reference count, but not setting idev->dev to NULL is 
> > a sign something is wrong...
> 
> If anything this is more of a BUG trap than a true correctness patch,
> but either way if you want me to apply this please formally submit
> this with a proper commit message and signoff, thanks!

This was not a patch for inclusion, this was to show my point.
I suspect this will trigger NULL dereference at some points later...

I do think a correct patch would be to change ipv6 to mimic ipv4 way of
course. I'll take a look at this later.

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html