netdev - Re: [PATCH 1/2] atl1: fix resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimAUO0+z8oUpm+LrhY-=7ge9iJd=e8TMfsXeOj0@mail.gmail.com>
Date:	Thu, 16 Sep 2010 16:13:54 -0400
From:	Chris Snook <chris.snook@...il.com>
To:	Luca Tettamanti <kronos.it@...il.com>
Cc:	netdev@...r.kernel.org, atl1-devel@...ts.sourceforge.net,
	jcliburn@...il.com, jie.yang@...eros.com, stable@...nel.org
Subject: Re: [PATCH 1/2] atl1: fix resume

On Thu, Sep 16, 2010 at 3:29 PM, Luca Tettamanti <kronos.it@...il.com> wrote:
> adapter->cmb.cmb is initialized when the device is opened and freed when
> it's closed. Accessing it unconditionally during resume results either
> in a crash (NULL pointer dereference, when the interface has not been
> opened yet) or data corruption (when the interface has been used and
> brought down adapter->cmb.cmb points to a deallocated memory area).
>
> Cc: stable@...nel.org
> ---
>  drivers/net/atlx/atl1.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
> index 63b9ba0..bbd6e30 100644
> --- a/drivers/net/atlx/atl1.c
> +++ b/drivers/net/atlx/atl1.c
> @@ -2847,10 +2847,11 @@ static int atl1_resume(struct pci_dev *pdev)
>        pci_enable_wake(pdev, PCI_D3cold, 0);
>
>        atl1_reset_hw(&adapter->hw);
> -       adapter->cmb.cmb->int_stats = 0;
>
> -       if (netif_running(netdev))
> +       if (netif_running(netdev)) {
> +               adapter->cmb.cmb->int_stats = 0;
>                atl1_up(adapter);
> +       }
>        netif_device_attach(netdev);
>
>        return 0;
> --
> 1.7.1
>
>

Thanks.  I confirmed that the other atlx drivers (which I have been
reminded I need to finish merging into a single driver) do not have
this bug.

Acked-by: Chris Snook <chris.snook@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html