netdev - Re: [PATCH net-next2.6] ipv4: ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100915.220522.25138138.davem@davemloft.net>
Date:	Wed, 15 Sep 2010 22:05:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, linville@...driver.com
Subject: Re: [PATCH net-next2.6] ipv4: ip_ptr cleanups

From: David Miller <davem@...emloft.net>
Date: Wed, 15 Sep 2010 21:43:35 -0700 (PDT)

> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Wed, 15 Sep 2010 16:04:31 +0200
> 
>> dev->ip_ptr is protected by rtnl and rcu.
>> 
>> Yet some places dont use appropriate primitives and/or locking rules.
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Applied, thanks a lot Eric.

Eric this introduces a build failure when lockdep or RCU checking
is enabled.

The problem is that inetdevice.h now references lockdep_rtnl_is_held()
but does not include rtnetlink.h

I'll simply ammend your commit with that header include added.

Just FYI...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html