netdev - Re: [E1000-devel] [PATCH] net: enable GRO by default for vlan devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100915.225146.35823170.davem@davemloft.net>
Date:	Wed, 15 Sep 2010 22:51:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	eric.dumazet@...il.com, bphilips@...e.de,
	e1000-devel@...ts.sourceforge.net, bruce.w.allan@...el.com,
	jesse.brandeburg@...el.com, john.ronciak@...el.com,
	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	bhutchings@...arflare.com
Subject: Re: [E1000-devel] [PATCH] net: enable GRO by default for vlan
 devices

From: Stephen Hemminger <shemminger@...tta.com>
Date: Wed, 15 Sep 2010 18:16:16 -0700

> On Thu, 16 Sep 2010 00:28:11 +0200
> Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
>> BTW, we have a similar problem for bonding ( GRO is disabled )
>> 
>> # ethtool -K bond0 gro off
>> # ethtool -K bond0 gro on
>> Cannot set device GRO settings: Invalid argument
>> 
>> Same for vlans on top of bond0
> 
> Bridge has same problem as well.

Looking this over it should be a simple matter of:

1) Adding the generic get/set gro ethtool ops to bonding
   and bridge device ops.

2) Set NETIF_F_GRO in bond/bridge device flags

3) Maybe some minor fiddling with netdev_increment_features
   and the flag macros it uses?

Patches welcome :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html