netdev - Re: [E1000-devel] [PATCH] net: enable GRO by default for vlan devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100915181616.578fcd37@nehalam>
Date:	Wed, 15 Sep 2010 18:16:16 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Brandon Philips <bphilips@...e.de>,
	e1000-devel@...ts.sourceforge.net, bruce.w.allan@...el.com,
	jesse.brandeburg@...el.com, john.ronciak@...el.com,
	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	Ben Hutchings <bhutchings@...arflare.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [E1000-devel] [PATCH] net: enable GRO by default for vlan
 devices

On Thu, 16 Sep 2010 00:28:11 +0200
Eric Dumazet <eric.dumazet@...il.com> wrote:

> Le jeudi 16 septembre 2010 à 00:03 +0200, Eric Dumazet a écrit :
> > Le mercredi 15 septembre 2010 à 12:24 -0700, Brandon Philips a écrit :
> > > Currently vlan devices don't have GRO by default as none of the Ethernet
> > > drivers add NETIF_F_GRO to their vlan_features.
> > > 
> > > As GRO is a software feature add GRO to dev->vlan_features in
> > > register_netdevice() and let vlan_dev_init() take care that it gets
> > > enabled only when dev->features has NETIF_F_GRO too.
> > > 
> > > Signed-off-by: Brandon Philips <bphilips@...e.de>
> > > 
> > 
> > Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> > 
> 
> BTW, we have a similar problem for bonding ( GRO is disabled )
> 
> # ethtool -K bond0 gro off
> # ethtool -K bond0 gro on
> Cannot set device GRO settings: Invalid argument
> 
> Same for vlans on top of bond0

Bridge has same problem as well.


-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html