netdev - Re: [PATCH net-next-2.6 1/2] ethtool, ixgbe: Move RX n-tuple mask fixup to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100917.165341.140752835.davem@davemloft.net>
Date:	Fri, 17 Sep 2010 16:53:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	peter.p.waskiewicz.jr@...el.com, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com,
	e1000-devel@...ts.sourceforge.net, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com, bruce.w.allan@...el.com,
	alexander.h.duyck@...el.com, john.ronciak@...el.com
Subject: Re: [PATCH net-next-2.6 1/2] ethtool, ixgbe: Move RX n-tuple mask
 fixup to ethtool

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 16 Sep 2010 22:28:07 +0100

> The ethtool utility does not set masks for flow parameters that are
> not specified, so if both value and mask are 0 then this must be
> treated as equivalent to a mask with all bits set.  Currently that is
> done in the only driver that implements RX n-tuple filtering, ixgbe.
> Move it to the ethtool core.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Looks good to me, applied, thanks Ben.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html