netdev - Re: [PATCH net-next-2.6] net: shrinks struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100916.215914.228953982.davem@davemloft.net>
Date:	Thu, 16 Sep 2010 21:59:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, jpirko@...hat.com
Subject: Re: [PATCH net-next-2.6] net: shrinks struct net_device

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 16 Sep 2010 14:58:13 +0200

> commit ab95bfe01 (net: replace hooks in __netif_receive_skb) added
> rx_handler at wrong place, between two cache line aligned objects,
> creating a big hole (a full cache line)
> 
> Move rx_handler and rx_handler_data before rx_queue, filling existing
> hole.
> 
> Move master field in the cache line(s) used in receive path.
> 
> This saves 64 bytes (or L1_CACHE_BYTES), and avoids two possible
> cache misses in receive path.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Also applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html