netdev - Re: [v2 RFC PATCH 2/4] Changes for virtio-net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF374A97D5.0C56095D-ON652577A1.00485CC0-652577A1.0049190A@in.ibm.com>
Date:	Fri, 17 Sep 2010 18:50:51 +0530
From:	Krishna Kumar2 <krkumar2@...ibm.com>
To:	Krishna Kumar2 <krkumar2@...ibm.com>
Cc:	anthony@...emonkey.ws, arnd@...db.de, avi@...hat.com,
	davem@...emloft.net, Eric Dumazet <eric.dumazet@...il.com>,
	kvm@...r.kernel.org, mst@...hat.com, netdev@...r.kernel.org,
	rusty@...tcorp.com.au
Subject: Re: [v2 RFC PATCH 2/4] Changes for virtio-net

> Krishna Kumar2/India/IBM@...IN
> Sent by: netdev-owner@...r.kernel.org

> > > +
> > >  struct virtnet_info {
> > >     struct virtio_device *vdev;
> > > -   struct virtqueue *rvq, *svq, *cvq;
> > > +   int numtxqs;         /* Number of tx queues */
> > > +   struct send_queue *sq;
> > > +   struct virtqueue *rvq;
> > > +   struct virtqueue *cvq;
> > >     struct net_device *dev;
> >
> > struct napi will probably be dirtied by RX processing
> >
> > You should make sure it doesnt dirty cache line of above (read mostly)
> > fields
>
> I am changing the layout of napi wrt other pointers in
> this patch, though the to-be-submitted RX patch does that.
> Should I do something for this TX-only patch?

Sorry, I think my sentence is not clear! I will make this
change (and also cache-line align the send queues), test
and let you know the result.

Thanks,

- KK

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html