netdev - Re: [PATCHv2 NEXT 2/5] qlcnic: vlan gro support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100917.112455.191154697.davem@davemloft.net>
Date:	Fri, 17 Sep 2010 11:24:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amit.salecha@...gic.com
Cc:	netdev@...r.kernel.org, ameen.rahman@...gic.com,
	anirban.chakraborty@...gic.com
Subject: Re: [PATCHv2 NEXT 2/5] qlcnic: vlan gro support

From: Amit Kumar Salecha <amit.salecha@...gic.com>
Date: Thu, 16 Sep 2010 22:14:40 -0700

> @@ -796,7 +796,7 @@ qlcnic_set_netdev_features(struct qlcnic_adapter *adapter,
>  	features = (NETIF_F_SG | NETIF_F_IP_CSUM |
>  			NETIF_F_IPV6_CSUM | NETIF_F_GRO);
>  	vlan_features = (NETIF_F_SG | NETIF_F_IP_CSUM |
> -			NETIF_F_IPV6_CSUM);
> +			NETIF_F_IPV6_CSUM | NETIF_F_GRO);
>  
>  	if (adapter->capabilities & QLCNIC_FW_CAPABILITY_TSO) {
>  		features |= (NETIF_F_TSO | NETIF_F_TSO6);
> @@ -1456,7 +1456,7 @@ qlcnic_setup_netdev(struct qlcnic_adapter *adapter,
>  	netdev->features |= (NETIF_F_SG | NETIF_F_IP_CSUM |
>  		NETIF_F_IPV6_CSUM | NETIF_F_GRO | NETIF_F_HW_VLAN_RX);
>  	netdev->vlan_features |= (NETIF_F_SG | NETIF_F_IP_CSUM |
> -		NETIF_F_IPV6_CSUM);
> +		NETIF_F_IPV6_CSUM | NETIF_F_GRO);
>  
>  	if (adapter->capabilities & QLCNIC_FW_CAPABILITY_TSO) {

Drivers no longer should set NETIF_F_GRO in their vlan_features
flags, the generic networking core does this for you now in
register_netdevice() in net-next-2.6

Please respin this patch with these settings removed.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html