netdev - Re: [PATCH v4] Gigabit Ethernet driver of Topcliff PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100917.230846.226755853.davem@davemloft.net>
Date:	Fri, 17 Sep 2010 23:08:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	masa-korg@....okisemi.com
Cc:	randy.dunlap@...cle.com, john.linn@...inx.com, ralf@...ux-mips.org,
	kristoffer@...sler.com, mbizon@...ebox.fr,
	gregory.v.rose@...el.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, rjw@...k.pl,
	okada533@....okisemi.com, shimizu394@....okisemi.com,
	morinaga526@....okisemi.com, qi.wang@...el.com,
	yong.y.wang@...el.com, andrew.chih.howe.khor@...el.com,
	joel.clark@...el.com, margie.foster@...el.com,
	arjan@...ux.intel.com
Subject: Re: [PATCH v4] Gigabit Ethernet driver of Topcliff PCH

From: Masayuki Ohtake <masa-korg@....okisemi.com>
Date: Wed, 15 Sep 2010 22:36:09 +0900

> +struct pch_gbe_regs_mac_adr {
> +	u32 high;
> +	u32 low;
> +} __attribute__ ((packed));;
 ...
> +struct pch_gbe_regs {
 ...
> +} __attribute__ ((packed));
...
> +struct pch_gbe_rx_desc {
 ...
> +} __attribute__ ((packed));;
 ...
> +struct pch_gbe_tx_desc {
 ...
> +} __attribute__ ((packed));;

The packed attribute should not be necessary for any of these
datastructures, so unless you can prove they are needed please
remove the attribute tag.

Besides being unnecessary, it will make cpu access to these
descriptors extremely slow on risc cpus, as the compiler will
emit byte-at-a-time accesses for all members of the structure
larger than one byte.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html