netdev - Re: [PATCH] xfrm: Allow different selector family in temporary state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100920.111149.45908739.davem@davemloft.net>
Date:	Mon, 20 Sep 2010 11:11:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	steffen.klassert@...unet.com
Cc:	herbert@...dor.apana.org.au, thomas.egerer@...unet.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] xfrm: Allow different selector family in temporary
 state

From: Steffen Klassert <steffen.klassert@...unet.com>
Date: Mon, 20 Sep 2010 13:52:53 +0200

> From: Thomas Egerer <thomas.egerer@...unet.com>
> 
> The family parameter xfrm_state_find is used to find a state matching a
> certain policy. This value is set to the template's family
> (encap_family) right before xfrm_state_find is called.
> The family parameter is however also used to construct a temporary state
> in xfrm_state_find itself which is wrong for inter-family scenarios
> because it produces a selector for the wrong family. Since this selector
> is included in the xfrm_user_acquire structure, user space programs
> misinterpret IPv6 addresses as IPv4 and vice versa.
> This patch splits up the original init_tempsel function into a part that
> initializes the selector respectively the props and id of the temporary
> state, to allow for differing ip address families whithin the state.
> 
> Signed-off-by: Thomas Egerer <thomas.egerer@...unet.com>
> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>

Looks good, applied, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html