netdev - Re: [PATCH] Fix race in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100920.154241.183059064.davem@davemloft.net>
Date:	Mon, 20 Sep 2010 15:42:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	tdm.code@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] Fix race in tcp_poll

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 20 Sep 2010 23:54:06 +0200

> Le lundi 20 septembre 2010 à 12:18 -0700, Tom Marshall a écrit :
>> If a RST comes in immediately after checking sk->sk_err, tcp_poll will
>> return POLLIN but not POLLOUT.  Fix this by checking sk->sk_err at the end
>> of tcp_poll.  Additionally, ensure the correct order of operations on SMP
>> machines with memory barriers.
>> 
>> Signed-off-by: Tom Marshall <tdm.code@...il.com>
...
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Maybe this is the last time we can avoid taking socket lock in
> tcp_poll() ;)

:-)  Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html