netdev - Re: [PATCH v2] xmit_compl_seq: information to reclaim vmsplice buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1285105624.6378.24.camel@edumazet-laptop>
Date:	Tue, 21 Sep 2010 23:47:04 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, sridharr@...gle.com
Subject: Re: [PATCH v2] xmit_compl_seq: information to reclaim vmsplice
 buffers

Le mardi 21 septembre 2010 à 23:39 +0200, Eric Dumazet a écrit :

> > + * Copy the first unacked seq into the receive msg control part.
> > + */
> > +static inline void tcp_sock_xmit_compl_seq(struct msghdr *msg,
> > +					   struct sock *sk)
> > +{
> > +	if (sock_flag(sk, SOCK_XMIT_COMPL_SEQ)) {
> > +		struct tcp_sock *tp = tcp_sk(sk);
> > +		if (msg->msg_controllen >= sizeof(tp->snd_una)) {
	
and this check is not necessary or correct ?

to put_cmsg() an u32, you need CMSG_LEN(4) bytes

> > +			put_cmsg(msg, SOL_SOCKET, SCM_XMIT_COMPL_SEQ,
> > +			    sizeof(tp->snd_una), &tp->snd_una);
> > +		}
> > +	}
> > +}

->

 if (sock_flag(sk, SOCK_XMIT_COMPL_SEQ))
	put_cmsg(msg, SOL_SOCKET, SCM_XMIT_COMPL_SEQ,
		 sizeof(u32), &snd_una);



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html