netdev - RE: [PATCH] cxgbi: bug fixes and code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8A71B368A89016469F72CD08050AD334086AC20E@maui.asicdesigners.com>
Date:	Wed, 22 Sep 2010 13:52:07 -0700
From:	"Karen Xie" <kxie@...lsio.com>
To:	"Mike Christie" <michaelc@...wisc.edu>
Cc:	<netdev@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
	<open-iscsi@...glegroups.com>,
	"Rakesh Ranjan" <rakesh@...lsio.com>,
	<James.Bottomley@...senPartnership.com>, <davem@...emloft.net>
Subject: RE: [PATCH] cxgbi: bug fixes and code cleanup

Thanks, Mike.
I will fix the patch and break it into per change.
Karen

-----Original Message-----
From: Mike Christie [mailto:michaelc@...wisc.edu] 
Sent: Wednesday, September 22, 2010 1:10 PM
To: Karen Xie
Cc: netdev@...r.kernel.org; linux-scsi@...r.kernel.org;
open-iscsi@...glegroups.com; Rakesh Ranjan;
James.Bottomley@...senPartnership.com; davem@...emloft.net
Subject: Re: [PATCH] cxgbi: bug fixes and code cleanup

On 09/21/2010 11:09 AM, kxie@...lsio.com wrote:
> [PATCH] cxgbi: bug fixes and code cleanup
>
> From: Karen Xie<kxie@...lsio.com>
>
> The patch includes the following changes.
> - removed un-used code
> - renamed alloc_cpl() to alloc_wr().
> - fixed connecting over VLAN.
> - updated cxgb4i connection setting and pagepod programming.

Could you break up the patch into a patch per change next time?


> -				read_lock(&csk->callback_lock);
>   				dskb = skb_peek(&csk->receive_queue);
>   				if (!dskb) {
>
read_unlock(&csk->callback_lock);

I think you also have to remove this read_unlock call.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html