netdev - Re: [PATCH] Use firmware provided index to register a network interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100923163336.GA15603@kroah.com>
Date:	Thu, 23 Sep 2010 09:33:36 -0700
From:	Greg KH <greg@...ah.com>
To:	Narendra_K@...l.com
Cc:	netdev@...r.kernel.org, linux-hotplug@...r.kernel.org,
	linux-pci@...r.kernel.org, Matt_Domsch@...l.com,
	Charles_Rose@...l.com, Jordan_Hargrave@...l.com,
	Vijay_Nijhawan@...l.com
Subject: Re: [PATCH] Use firmware provided index to register a network
 interface

On Thu, Sep 23, 2010 at 09:20:57PM +0530, Narendra_K@...l.com wrote:
> > Now trying to change the kernel namespace itself seems like a bad hack
> > around this fact.
> > 
> 
> The patch does not change the existing kernel name space.

You are "reordering it", right?

> It adheres to the existing ethN name space with IFNAMSIZ length
> requirements. The patch only makes sure that eth0 always corresponds
> to what is labeled as 'Gb1' on server chassis, on systems where SMBIOS
> type 41 record is available. And removes the need for any renames for
> the interfaces which have a firmware index assigned by system
> firmware, as the very first name assigned by the kernel will be as
> expected and deterministic.

And on systems with buggy firmware, what is going to happen here?  And
yes, there will be buggy BIOS tables, we can guarantee that, as this is
not something that Windows supports, right?

You are also complicating the logic for 99% of the world that will never
use this feature.  But I'll leave that up to the netdev developers to
decide, it's their code to maintain over time, not mine :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html