netdev - Re: [PATCH net-next-2.6] net: skb_frag_t can be smaller on small arches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100923.120516.123994233.davem@davemloft.net>
Date:	Thu, 23 Sep 2010 12:05:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net: skb_frag_t can be smaller on small
 arches

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 23 Sep 2010 17:06:54 +0200

> David
> 
> I remember you reacted on my three years old comment about
> commit a309bb072b96bfe (Page offsets and lengths need to be __u32.)
> 
> http://www.mail-archive.com/netdev@vger.kernel.org/msg43999.html
> 
> Could we reconsider the thing now and allow to shrink
> sizeof(skb_shared_info) from 0x104 to 0xbc, considering nothing happened
> about scatterlist work ?
> 
> This saves 128 bytes on i386 because of alignments, and can be reverted
> pretty fast if needed.

Yes, this seems reasonable.  I'll probably apply this, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html