netdev - Re: [PATCHv5] net: Add batman-adv meshing protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100924.134334.28812338.davem@davemloft.net>
Date:	Fri, 24 Sep 2010 13:43:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sven.eckelmann@....de
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: [PATCHv5] net: Add batman-adv meshing protocol

From: Sven Eckelmann <sven.eckelmann@....de>
Date: Sat, 18 Sep 2010 21:03:30 +0200

> B.A.T.M.A.N. (better approach to mobile ad-hoc networking) is a routing
> protocol for multi-hop ad-hoc mesh networks. The networks may be wired or
> wireless. See http://www.open-mesh.org/ for more information and user space
> tools.
> 
> Signed-off-by: Sven Eckelmann <sven.eckelmann@....de>

The only thing remaining which I really don't like is this hash helper
library thing in here.

It's a terrible abstraction and very inefficient.  Iteration uses
function calls, as does removal.  Key comparisons use callbacks, via
indirection function pointers, also very inefficient.

Just use the "struct hlist_head" and "struct hlist_node" objects we
have generically already.  Inline the list iteration, as well as the
key comparisons and the node linking/unlinking.

Otherwise if you think your hash helpers are so incredibly useful,
propose for their inclusion under lib/ on linux-kernel

But frankly, I wish you a lot of luck with that. :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html