netdev - Re: [PATCH 1/1] net-gre: clear skb->queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1285397206.2478.97.camel@edumazet-laptop>
Date:	Sat, 25 Sep 2010 08:46:46 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	chavey@...gle.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH 1/1] net-gre: clear skb->queue_mapping in GRE recv path

Le vendredi 24 septembre 2010 à 16:18 -0700, chavey@...gle.com a écrit :
> From: chavey <chavey@...gle.com>
> Date: Fri, 24 Sep 2010 15:05:02 -0700
> 
> A continuous stream of errors:
> 
>   slbgre0 received packet on queue [123], but number of RX queues is 1
>   net_ratelimit: 155786 callbacks suppressed
> 
> is filling up /var/log/messages.
> 
> This is due to not unsetting skb->queue_mapping in the GRE receive path.
> 
> Signed-off-by: chavey <chavey@...gle.com>
> ---
>  net/ipv4/ip_gre.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
> index 945b20a..53bdb97 100644
> --- a/net/ipv4/ip_gre.c
> +++ b/net/ipv4/ip_gre.c
> @@ -641,6 +641,7 @@ static int ipgre_rcv(struct sk_buff *skb)
>  		}
>  
>  		skb_tunnel_rx(skb, tunnel->dev);
> +		skb_set_queue_mapping(skb, 0);
>  
>  		skb_reset_network_header(skb);
>  		ipgre_ecn_decapsulate(iph, skb);


Laurent

Please use you full name in your signature, 

Then, have you seen Tom Herbert patch yesterday ?

http://patchwork.ozlabs.org/patch/65583/

He suggested to place this skb_set_queue_mapping(skb, 0) inside
skb_tunnel_rx(), so that we dont patch every tunnel driver ...

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html