netdev - Re: [PATCH] 3c59x: fix regression from patch "Add ethtool WOL support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100927.110803.220069414.davem@davemloft.net>
Date:	Mon, 27 Sep 2010 11:08:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	JBeulich@...ell.com
Cc:	andrew@...displaytech.com, netdev@...r.kernel.org
Subject: Re: [PATCH] 3c59x: fix regression from patch "Add ethtool WOL
 support"

From: "Jan Beulich" <JBeulich@...ell.com>
Date: Mon, 27 Sep 2010 12:37:49 +0100

> This patch (commit 690a1f2002a3091bd18a501f46c9530f10481463) added a
> new call site for acpi_set_WOL() without checking that the function is
> actually suitable to be called via
> 
>  vortex_set_wol+0xcd/0xe0 [3c59x]
>  dev_ethtool+0xa5a/0xb70
>  dev_ioctl+0x2e0/0x4b0
>  T.961+0x49/0x50
>  sock_ioctl+0x47/0x290
>  do_vfs_ioctl+0x7f/0x340
>  sys_ioctl+0x80/0xa0
>  system_call_fastpath+0x16/0x1b
> 
> i.e. outside of code paths run when the device is not yet enabled or
> already disabled. In particular, putting the device into D3hot is a
> pretty bad idea when it was already brought up.
> 
> Furthermore, all prior callers of the function made sure they're
> actually dealing with a PCI device, while the newly added one didn't.
> 
> In the same spirit, the .get_wol handler shouldn't indicate support
> for WOL for non-PCI devices.
> 
> Signed-off-by: Jan Beulich <jbeulich@...ell.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html