netdev - Re: [PATCH -next 2/4] ip_gre: percpu stats accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1285594140.2263.0.camel@achroite.uk.solarflarecom.com>
Date:	Mon, 27 Sep 2010 14:29:00 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH -next 2/4] ip_gre: percpu stats accounting

On Mon, 2010-09-27 at 12:35 +0200, Eric Dumazet wrote:
> Maintain per_cpu tx_bytes, tx_packets, rx_bytes, rx_packets.
> 
> Other seldom used fields are kept in netdev->stats structure, possibly
> unsafe.
> 
> This is a preliminary work to support lockless transmit path, and
> correct RX stats, that are already unsafe.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> ---
>  net/ipv4/ip_gre.c |  138 +++++++++++++++++++++++++++++++-------------
>  1 file changed, 99 insertions(+), 39 deletions(-)
> 
> diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
> index 5d6ddcb..de39b22 100644
> --- a/net/ipv4/ip_gre.c
> +++ b/net/ipv4/ip_gre.c
[...]
> @@ -377,7 +405,7 @@ static struct ip_tunnel *ipgre_tunnel_locate(struct net *net,
>  	if (parms->name[0])
>  		strlcpy(name, parms->name, IFNAMSIZ);
>  	else
> -		sprintf(name, "gre%%d");
> +		strcpy(name, "gre%d");
>  
>  	dev = alloc_netdev(sizeof(*t), name, ipgre_tunnel_setup);
>  	if (!dev)
[...]

This is a valid fix, but doesn't belong in this patch!

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html