netdev - Re: [Bugme-new] [Bug 18952] New: The mount of SYN retries is not equal to /proc/sys/net/ipv4/tcp_syn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1009281244040.26447@wel-95.cs.helsinki.fi>
Date:	Tue, 28 Sep 2010 12:47:23 +0300 (EEST)
From:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
To:	Yuri Chislov <yuri@...nteg.net>
cc:	David Miller <davem@...emloft.net>, damian@....rwth-aachen.de,
	Andrew Morton <akpm@...ux-foundation.org>,
	Netdev <netdev@...r.kernel.org>,
	bugzilla-daemon@...zilla.kernel.org,
	bugme-daemon@...zilla.kernel.org
Subject: Re: [Bugme-new] [Bug 18952] New: The mount of SYN retries is not
 equal to /proc/sys/net/ipv4/tcp_syn_retries

On Tue, 28 Sep 2010, Yuri Chislov wrote:

>  What is advantage in the replace compare by calculation?
> Please clarify, if possible.
> Thanks.
> Yuri.     

If you did take this from kernel history, reading the particular log 
message might have helped?!?

> --- linux-2.6.31.14/net/ipv4/tcp_timer.c        2010-07-05 17:11:43.000000000 
> +0000
> +++ linux-2.6.32.15/net/ipv4/tcp_timer.c        2010-06-01 16:56:03.000000000 
> +0000
> @@ -137,13 +137,14 @@
>  {
>         struct inet_connection_sock *icsk = inet_csk(sk);
>         int retry_until;
> +       bool do_reset;
>  
>         if ((1 << sk->sk_state) & (TCPF_SYN_SENT | TCPF_SYN_RECV)) {
>                 if (icsk->icsk_retransmits)
>                         dst_negative_advice(&sk->sk_dst_cache);
>                 retry_until = icsk->icsk_syn_retries ? : 
> sysctl_tcp_syn_retries;
>         } else {
> -               if (icsk->icsk_retransmits >= sysctl_tcp_retries1) {
> +               if (retransmits_timed_out(sk, sysctl_tcp_retries1)) {
>                         /* Black hole detection */
>                         tcp_mtu_probing(icsk, sk);
>  
> @@ -155,13 +156,15 @@
>                         const int alive = (icsk->icsk_rto < TCP_RTO_MAX);
>  
>                         retry_until = tcp_orphan_retries(sk, alive);
> +                       do_reset = alive ||
> +                                  !retransmits_timed_out(sk, retry_until);
>  
> -                       if (tcp_out_of_resources(sk, alive || icsk-
> >icsk_retransmits < retry_until))
> +                       if (tcp_out_of_resources(sk, do_reset))
>                                 return 1;
>                 }
>         }
>  
> -       if (icsk->icsk_retransmits >= retry_until) {
> +       if (retransmits_timed_out(sk, retry_until)) {
>                 /* Has it gone just too far? */
>                 tcp_write_err(sk);
>                 return 1;
> @@ -279,7 +282,7 @@
>   *     The TCP retransmit timer.
>   */
>  
> -static void tcp_retransmit_timer(struct sock *sk)
> +void tcp_retransmit_timer(struct sock *sk)
>  {
>         struct tcp_sock *tp = tcp_sk(sk);
>         struct inet_connection_sock *icsk = inet_csk(sk);
> @@ -385,7 +388,7 @@
>  out_reset_timer:
>         icsk->icsk_rto = min(icsk->icsk_rto << 1, TCP_RTO_MAX);
>         inet_csk_reset_xmit_timer(sk, ICSK_TIME_RETRANS, icsk->icsk_rto, 
> TCP_RTO_MAX);
> -       if (icsk->icsk_retransmits > sysctl_tcp_retries1)
> +       if (retransmits_timed_out(sk, sysctl_tcp_retries1 + 1))
>                 __sk_dst_reset(sk);
>  
>  out:;
> @@ -499,8 +502,7 @@
>         elapsed = tcp_time_stamp - tp->rcv_tstamp;
>  
>         if (elapsed >= keepalive_time_when(tp)) {
> -               if ((!tp->keepalive_probes && icsk->icsk_probes_out >= 
> sysctl_tcp_keepalive_probes) ||
> -                    (tp->keepalive_probes && icsk->icsk_probes_out >= tp-
> >keepalive_probes)) {
> +               if (icsk->icsk_probes_out >= keepalive_probes(tp)) {
>                         tcp_send_active_reset(sk, GFP_ATOMIC);
>                         tcp_write_err(sk);


-- 
 i.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html