netdev - Re: bonding vs GSO vs checksumming.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100928032100.GA24983@gondor.apana.org.au>
Date:	Tue, 28 Sep 2010 12:21:00 +0900
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Maciej Żenczykowski <zenczykowski@...il.com>
Cc:	Linux NetDev <netdev@...r.kernel.org>
Subject: Re: bonding vs GSO vs checksumming.

On Tue, Sep 28, 2010 at 11:49:07AM +0900, Herbert Xu wrote:
> On Thu, Sep 23, 2010 at 05:56:43PM -0700, Maciej Żenczykowski wrote:
> > I'm seeing the following:
> > 
> > bonding: caps=(0x1113a3, 0x1113ab) len=18192 data_len=18120 ip_summed=0
> > 
> > on a 2.6.34.5 based kernel originating from v6 tcp transmit (mtu 1280)
> > on a bonded device of tg3 (presumably with TSO6) and forcedeth
> > (presumably without TSO6).
> > 
> > I can't quite figure out what this truly means...
> 
> Did it come with a kernel backtrace?

Actually your particular problem should be fixed by

commit 6afff0caa721211e8c04bdc7627ee3bff95bcb95
Author: John Fastabend <john.r.fastabend@...el.com>
Date:   Wed Jun 16 14:18:12 2010 +0000

    net: consolidate netif_needs_gso() checks

which went in after 2.6.34.

However, the fact that your feature bits show that bonding is
declaring TSO6 support without IPv6 checksum support also means
that the bonding feature computation is broken.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html