netdev - Re: [PATCH] Add Qualcomm Gobi 2000 driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1285697500.1866.100.camel@Joe-Laptop>
Date:	Tue, 28 Sep 2010 11:11:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	Elly Jones <ellyjones@...gle.com>
Cc:	netdev@...r.kernel.org, dbrownell@...rs.sourceforge.net,
	mjg59@...f.ucam.org, jglasgow@...gle.com, msb@...gle.com,
	olofj@...gle.com
Subject: Re: [PATCH] Add Qualcomm Gobi 2000 driver.

On Tue, 2010-09-28 at 13:10 -0400, Elly Jones wrote:
> From: Elizabeth Jones <ellyjones@...gle.com>

Hi.

The readme is out of date and should be updated.

[]

> +#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,23)
> +	usbnet = usb_get_intfdata(iface);
> +#else
> +	usbnet = iface->dev.platform_data;
> +#endif

I think it's not particularly useful to include support
for versions < current when this driver is added.

[]

> +#define DBG(format, arg...) \
> +	if (debug == 1) { \
> +		printk(KERN_INFO "QCUSBNet2k::%s " format, __FUNCTION__, ## arg); \
> +	}

This should be surrounded by a do {} while(0)

#define DBG(fmt, arg...)							\
do {										\
	if (debug == 1)								\
		printk(KERN_INFO "QCUSBNet2k::%s " fmt, __func__, ##arg);	\
} while (0)

I think many of these DBG messages should
not use DBG but the more normal pr_<level>,
dev_<level> or netdev_<level> so generally
useful messages are logged without getting
all the debugging messages.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html