netdev - Re: [PATCH] [XFRM]: Don't dereference error pointer dst1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1285793113.5211.8.camel@edumazet-laptop>
Date:	Wed, 29 Sep 2010 22:45:13 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [XFRM]: Don't dereference error pointer dst1

Le jeudi 30 septembre 2010 à 00:37 +0200, Roel Kluin a écrit :
> Don't dereference dst1 when it's an error pointer.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
>  net/xfrm/xfrm_policy.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> I just noticed this by code analysis. It wasn't tested in any way.
> 
> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index cbab6e1..b186c3d 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -1414,13 +1414,14 @@ static struct dst_entry *xfrm_bundle_create(struct xfrm_policy *policy,
>  
>  	for (; i < nx; i++) {
>  		struct xfrm_dst *xdst = xfrm_alloc_dst(net, family);
> -		struct dst_entry *dst1 = &xdst->u.dst;
> +		struct dst_entry *dst1;
>  
>  		err = PTR_ERR(xdst);
>  		if (IS_ERR(xdst)) {
>  			dst_release(dst);
>  			goto put_states;
>  		}
> +		dst1 = &xdst->u.dst;
>  
>  		if (!dst_prev)
>  			dst0 = dst1;
> 

This is not a dereference, but a cast from "struct xfrm_dst *" to
"struct dst_entry *"




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html