lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100929061146.GA2439@angua.secretlab.ca> Date: Wed, 29 Sep 2010 15:11:46 +0900 From: Grant Likely <grant.likely@...retlab.ca> To: Michal Simek <monstr@...str.eu> Cc: linux-kernel@...r.kernel.org, john.williams@...alogix.com, edgar.iglesias@...il.com, duyl@...inx.com, linnj@...inx.com, microblaze-uclinux@...e.uq.edu.au, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org Subject: Re: [PATCH 4/7] net: emaclite: Add support for little-endian platforms On Wed, Sep 29, 2010 at 03:52:15PM +1000, Michal Simek wrote: > Upcomming Microblaze is little endian that's why is necessary > to fix protocol and length loading. > > Signed-off-by: Michal Simek <monstr@...str.eu> > CC: "David S. Miller" <davem@...emloft.net> > CC: Grant Likely <grant.likely@...retlab.ca> > CC: Eric Dumazet <eric.dumazet@...il.com> > CC: netdev@...r.kernel.org > CC: linux-kernel@...r.kernel.org > CC: devicetree-discuss@...ts.ozlabs.org This should go via davem, but it looks correct to me. Acked-by: Grant Likely <grant.likely@...retlab.ca> > --- > drivers/net/xilinx_emaclite.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/xilinx_emaclite.c b/drivers/net/xilinx_emaclite.c > index 71122ee..533ebb1 100644 > --- a/drivers/net/xilinx_emaclite.c > +++ b/drivers/net/xilinx_emaclite.c > @@ -430,8 +430,8 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data) > } > > /* Get the protocol type of the ethernet frame that arrived */ > - proto_type = ((in_be32(addr + XEL_HEADER_OFFSET + > - XEL_RXBUFF_OFFSET) >> XEL_HEADER_SHIFT) & > + proto_type = ((ntohl(in_be32(addr + XEL_HEADER_OFFSET + > + XEL_RXBUFF_OFFSET)) >> XEL_HEADER_SHIFT) & > XEL_RPLR_LENGTH_MASK); > > /* Check if received ethernet frame is a raw ethernet frame > @@ -439,9 +439,9 @@ static u16 xemaclite_recv_data(struct net_local *drvdata, u8 *data) > if (proto_type > (ETH_FRAME_LEN + ETH_FCS_LEN)) { > > if (proto_type == ETH_P_IP) { > - length = ((in_be32(addr + > + length = ((ntohl(in_be32(addr + > XEL_HEADER_IP_LENGTH_OFFSET + > - XEL_RXBUFF_OFFSET) >> > + XEL_RXBUFF_OFFSET)) >> > XEL_HEADER_SHIFT) & > XEL_RPLR_LENGTH_MASK); > length += ETH_HLEN + ETH_FCS_LEN; > -- > 1.5.5.1 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists