netdev - Re: [PATCH] ip_gre: CONFIG_IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100929071158.GA4684@gondor.apana.org.au>
Date:	Wed, 29 Sep 2010 16:11:58 +0900
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH] ip_gre: CONFIG_IPV6_MODULE support

On Wed, Sep 29, 2010 at 08:24:03AM +0200, Eric Dumazet wrote:
.
> Well, sometimes people wants to :
> 
> /etc/modprobe.conf
> install ipv6 /bin/true
> 
> 
> Yet, be able to load ip_gre as a module
> 
> so IPV6=m, GRE=m,

I think if we cared about this we should provide ways to disable
IPv6 (if there aren't any already) even when the module is loaded
or the code is built-in.

BTW, I think the code isn't 100% safe as is as it tries to access
skb_dst unconditionally in the IPv6 case.  If the packet came via
a remote source (e.g., bridging and virt) it may not have an IPv6
skb_dst at all.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html