netdev - Re: [PATCH] bonding: fix to rejoin multicast groups immediately

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100929131619.GA2857@redhat.com>
Date:	Wed, 29 Sep 2010 10:16:19 -0300
From:	Flavio Leitner <fbl@...hat.com>
To:	netdev@...r.kernel.org
Cc:	bonding-devel@...ts.sourceforge.net,
	Jay Vosburgh <fubar@...ibm.com>
Subject: Re: [PATCH] bonding: fix to rejoin multicast groups immediately


forgot CC to bonding-devel@...ts.sourceforge.net

On Wed, Sep 29, 2010 at 04:12:07AM -0300, Flavio Leitner wrote:
> It should rejoin multicast groups immediately when
> the failover happens to restore the multicast traffic.
> 
> Signed-off-by: Flavio Leitner <fleitner@...hat.com>
> ---
>  net/ipv4/igmp.c |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
> index 1fdcacd..b81d674 100644
> --- a/net/ipv4/igmp.c
> +++ b/net/ipv4/igmp.c
> @@ -1257,14 +1257,14 @@ void ip_mc_rejoin_group(struct ip_mc_list *im)
>  	if (im->multiaddr == IGMP_ALL_HOSTS)
>  		return;
>  
> -	if (IGMP_V1_SEEN(in_dev) || IGMP_V2_SEEN(in_dev)) {
> -		igmp_mod_timer(im, IGMP_Initial_Report_Delay);
> -		return;
> -	}
> -	/* else, v3 */
> -	im->crcount = in_dev->mr_qrv ? in_dev->mr_qrv :
> -		IGMP_Unsolicited_Report_Count;
> -	igmp_ifc_event(in_dev);
> +	/* a failover is happening and switches
> +	 * must be notified immediately */
> +	if (IGMP_V1_SEEN(in_dev))
> +		igmp_send_report(in_dev, im, IGMP_HOST_MEMBERSHIP_REPORT);
> +	else if (IGMP_V2_SEEN(in_dev))
> +		igmp_send_report(in_dev, im, IGMPV2_HOST_MEMBERSHIP_REPORT);
> +	else
> +		igmp_send_report(in_dev, im, IGMPV3_HOST_MEMBERSHIP_REPORT);
>  #endif
>  }
>  EXPORT_SYMBOL(ip_mc_rejoin_group);
> -- 
> 1.7.2.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Flavio
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html