netdev - Re: [PATCH net-next 1/2] enic: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100930114958.59c438d7@s6510>
Date:	Thu, 30 Sep 2010 11:49:58 +0900
From:	Stephen Hemminger <shemminger@...tta.com>
To:	"Vasanthy Kolluri (vkolluri)" <vkolluri@...co.com>
Cc:	<netdev@...r.kernel.org>,
	"Scott Feldman (scofeldm)" <scofeldm@...co.com>,
	"Roopa Prabhu (roprabhu)" <roprabhu@...co.com>,
	"David Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 1/2] enic: remove dead code

On Wed, 29 Sep 2010 17:10:00 -0700
"Vasanthy Kolluri (vkolluri)" <vkolluri@...co.com> wrote:

> Hi Stephen,
> 
>  
> 
> Thanks a lot for submitting this patch. However, I have got few
> concerns:
> 
>  
> 
> 1.       Need to retain vnic_dev_soft_reset and vnic_dev_soft_reset_done
> as they are used in vnic_dev_hang_reset and vnic_dev_hang_reset_done
> respectively
> 
> 2.       Want to retain enic_set_rss_key and enic_set_rss_cpu as we will
> be using those in the near future for adding multi rq functionality to
> enic. 
> 
> 3.       Additional cleanup in vnic_rss.h. FYI, the struct defines in
> vnic_rss.h are currently not in use. But I retained them for the same
> reason as in #2.

Ok, but Linux tree is not the repository for "possible future enhancements".
Do it or remove it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html