[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1285948569.752.38.camel@Joe-Laptop>
Date: Fri, 01 Oct 2010 08:56:09 -0700
From: Joe Perches <joe@...ches.com>
To: Elly Jones <ellyjones@...gle.com>
Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
dbrownell@...rs.sourceforge.net, mjg59@...f.ucam.org,
jglasgow@...gle.com, msb@...gle.com, olofj@...gle.com
Subject: Re: [PATCH 0/2] qcusbnet: Cleanups
On Fri, 2010-10-01 at 10:42 -0400, Elly Jones wrote:
> On Thu, Sep 30, 2010 at 05:45:35PM -0700, Joe Perches wrote:
> > These cleanups are meant for Elly Jones on top
> > of the Qualcomm Gobi 2000 driver she submitted.
> Wow, thank you! I'll incorporate your fixes, make sure I have clean
> checkpatch output, and send a v2.
Hi Elly,
I wouldn't go overboard on checkpatch compliance.
I think you can ignore several messages. I did.
Braces around single line statements are ok by me.
80+ column lines don't bother me much.
Probably the extern qcusbnet_debug should go into
some .h file though.
cheers, Joe
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists